Fix Toggle Last Opened Bottom Panel not working after restoring FileSystem Dock to the side #94053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystem Dock to the side
KoBeWi
reviewed
Jul 10, 2024
| if (was_visible) { | ||
| // Open the first panel to ensure that if the removed dock was visible, the bottom | ||
| // panel will not collapse. | ||
| _switch_to_item(true, 0); |
There was a problem hiding this comment.
I wonder if it's better to close the panel instead 🤔
I don't see why would you want to open Output in this case.
There was a problem hiding this comment.
I'm 50/50 on this one personally. I'd say we should keep this PR's behavior as-is and change it if there's significant justified pushback.
There was a problem hiding this comment.
I tend to agree with @Calinou, this behavior prevent the closing of the bottom panel when it's already opened. But it's really a personal taste at this point.
KoBeWi
approved these changes
Jul 10, 2024
Calinou
approved these changes
Jul 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications:
EditorPlugin::remove_control_from_bottom_panel), the bottom panel is kept closed andlast_opened_controlis updated for the first panel.