Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclear PROPERTY_USAGE_STORAGE/EDITOR description #94155

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix unclear PROPERTY_USAGE_STORAGE/EDITOR description #94155

merged 1 commit into from
Jul 17, 2024

Conversation

mickeyordog
Copy link
Contributor

Mentioned in this issue #93679

@mickeyordog mickeyordog requested a review from a team as a code owner July 9, 2024 23:23
@Mickeon
Copy link
Contributor

Mickeon commented Jul 9, 2024 •
edited
Loading

You forgot the period. When you make another commit, you may want to squash both commits. See the Pull Request Workflow.

@Mickeon Mickeon added this to the 4.3 milestone Jul 9, 2024
@mickeyordog
Copy link
Contributor Author

Done

Mickeon
Mickeon approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the small things that count.

(Commits still would need to be squashed)

@Mickeon Mickeon added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 10, 2024
@akien-mga akien-mga changed the title Fix unclear constant description Fix unclear PROPERTY_USAGE_STORAGE/EDITOR description Jul 17, 2024
@akien-mga akien-mga merged commit 37d0b5d into godotengine:master Jul 17, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mickeyordog @Mickeon @akien-mga