Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent confirm button being overridden to "Open" when in save file mode #94172

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Prevent confirm button being overridden to "Open" when in save file mode #94172

merged 1 commit into from
Jul 11, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #94166

@jsjtxietian jsjtxietian marked this pull request as ready for review July 10, 2024 11:49
@jsjtxietian jsjtxietian requested review from a team as code owners July 10, 2024 11:49
@HolonProduction
Copy link
Member

Applied it to master and can confirm that it solves the bug. Code looks straight forward.

@Calinou Calinou added bug topic:gui cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 10, 2024
@Calinou Calinou added this to the 4.3 milestone Jul 10, 2024
Calinou
Calinou approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@akien-mga akien-mga merged commit 383a6e4 into godotengine:master Jul 11, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the open-save branch July 11, 2024 07:47
@akien-mga akien-mga changed the title Prevent confirm button being override to "Open" when in save file mode Prevent confirm button being overridden to "Open" when in save file mode Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

FileDialog in FILE_MODE_SAVE_FILE reverts confirm button to "Open" instead of "Save" if you click a file
4 participants
@jsjtxietian @HolonProduction @akien-mga @Calinou