Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement preview thumbnail generation for 3D and layered textures #94600

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

BlueCube3310
Copy link
Contributor

@BlueCube3310 BlueCube3310 commented Jul 21, 2024

Allows preview generation of 3D and layered textures in the file manager and inspector.

master PR
b aa

TODO:

Testing project: layered-preview-test.zip

@Calinou
Copy link
Member

Calinou commented Jul 22, 2024

I wonder if the first layer should always be displayed, or whether we should display an intermediate layer halfway through (e.g. the 128th layer in a 256-layer image).

With some 3D data such as SDFs, the first layer may look like nothing meaningful (e.g. a pure red texture for baked particle collision SDFs).

You could compare this to video streaming websites where the automatically thumbnail is generally picked from the middle of the video, as opposed to its first frame.

@BlueCube3310 BlueCube3310 marked this pull request as ready for review July 23, 2024 12:16
@BlueCube3310 BlueCube3310 force-pushed the tex-layered-preview branch 2 times, most recently from c2700a6 to fc822a0 Compare July 23, 2024 19:41
@BlueCube3310
Copy link
Contributor Author

The middle layer is now used for generating previews.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 10, 2024
@akien-mga akien-mga merged commit d4b1d51 into godotengine:master Sep 11, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants