Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Fix text size rounding with MSDF fonts. #94606

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 22, 2024

Fixes #94545

Changes some RTL functions to use get_line_ascent(i) + get_line_descent(i) (can be fractional with MSDF) instead of get_linse_size(i) (rounded up bounding box).

@bruvzg bruvzg added this to the 4.3 milestone Jul 22, 2024
@bruvzg bruvzg requested review from a team as code owners July 22, 2024 04:50
@akien-mga akien-mga merged commit 6694f55 into godotengine:master Jul 22, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichTextLabel.get_line_offset returns incorrect value for MSDF fonts
2 participants