Android Editor: Make progress dialog visible again #94662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Jul 23, 2024
|
Can confirm the progress bar works well on the s23+ , pretty well!.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #94416, I noticed that the long hang was indeed a reimport, but there was no visible sign of it. Turns out that we prevented ProgressDialog from rendering anything, so it was stuck on the previous frame showing a FileSystem dock rescan at around 98% or 99%.
@m4gr3d suggested that this was disabled due to an input bug that has since been fixed, so it might be fine to re-enable. I've tested briefly on a Google Pixel 7a (with the TPS demo) and it seems to work ok.