Emit normal_roughness
compatibility code in custom functions
#94812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #94777
When reading from the normal_roughness buffer we need to emit compatibility code to ensure that the user gets proper normals even though the texture is stored in a custom format.
In master the compatibility code is only added when the normal_roughness uniform is used directly. When the normal_roughness uniform is passed as an argument to a custom function the compatibility code is not used.
This PR does two things:
As a bonus, we can now undo the restriction added in #72300 which forbid passing screen textures to custom functions when using XR shaders.