Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reimport file multiple scenes #95264

Merged

Conversation

Hilderin
Copy link
Contributor

@Hilderin Hilderin commented Aug 8, 2024

This PR fixes an issue that I introduced in #95225 when multiple Blender or GLB files are modified and reimported.

With PR #95225, only the last file was reloaded for each scene.

With this PR, I also managed to easily reload a scene only once, even if multiple objects need reloading in the scene.

Steps to reproduce the problem:

  • Open the MRP.
  • Open the scene "two_objects.tscn".
  • Modify both Blender files (without going back to Godot).
  • Go back to Godot.
  • The two modified objects should be updated.

This is an MRP with two Blender files:
two_objects.zip

@clayjohn
Copy link
Member

clayjohn commented Aug 8, 2024

I tested locally and could reproduce the issue. And I can confirm that this PR fixes the issue while not re-introducing the original problem fixed by #95225

@akien-mga akien-mga merged commit 9221294 into godotengine:master Aug 8, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants