Prevent to seek doubly on AnimationPlayerEditor #95405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Aug 12, 2024
KoBeWi
reviewed
Aug 12, 2024
TokageItLab
force-pushed
the
fix-double-seeking
branch
from
48c3f1d
to
81399ae
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps the fix for updating the drawing (maybe #93980) caused a double seek.
As I commented in #94420, Discrete gets the value of the previous key during reverse playback. The second time of the double seek is always updated with a positive 0 value, so the key to be acquired changes immediately after the reverse playback, which is the cause of #95391.
Ideally, we would remove the method call for the second seek, but for now I fix this by preventing the seek to the same time on the editor.