Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Android fileLastModified method to return values in seconds instead of milliseconds #95586

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Update the Android fileLastModified method to return values in seconds instead of milliseconds #95586

merged 1 commit into from
Aug 16, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Aug 15, 2024

Fixes #95576

@m4gr3d m4gr3d added bug platform:android topic:porting cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 15, 2024
@m4gr3d m4gr3d added this to the 4.4 milestone Aug 15, 2024
@m4gr3d m4gr3d requested a review from a team as a code owner August 15, 2024 19:27
@m4gr3d m4gr3d mentioned this pull request Aug 15, 2024
Closed
@akien-mga
Copy link
Member

So is that the proper fix for #94416, as we had a hunch that Android file modification implementation might be buggy?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Aug 15, 2024

So is that the proper fix for #94416, as we had a hunch that Android file modification implementation might be buggy?

No that logic actually uses the unix version, not the Android one.
From #94416 (comment), the unix version seems to have a bug on Android devices.

@akien-mga akien-mga merged commit a759867 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_last_modified_time_unit branch August 16, 2024 16:08
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:porting
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Incorrect date of project in Android Editor
3 participants
@m4gr3d @akien-mga @adamscott