Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-linear mapping for ReflectionProbe mip levels to match sky #96426

Merged

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Sep 1, 2024

Fixes: #85299

This is the same change from #69514 and it should have been applied to ReflectionProbes at that time.

This change isn't needed for the compatibility renderer because it uses a linear mapping of perceptual roughness to mipmap levels

Scene from the MRP (with roughness layers disabled for sky so the quality matches exactly)
Sky reflection
Screenshot 2024-09-01 at 12 35 18 AM
Probe reflection
Screenshot 2024-09-01 at 12 35 27 AM

@clayjohn clayjohn added this to the 4.4 milestone Sep 1, 2024
@clayjohn clayjohn requested a review from a team as a code owner September 1, 2024 08:44
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 63a8548 into godotengine:master Sep 3, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Godot 4 ReflectionProbes are much glossier than default sky reflection
4 participants