[Resource Loader] Do not check property type for non registered properties. #96780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 10, 2024
bruvzg
force-pushed
the
no_type_ed_settings
branch
from
003bf4e
to
3009073
Compare
|
Thanks! |
akien-mga
added a commit
that referenced
this pull request
Oct 4, 2024
Partially revert #96780, remove warnings from project/editor settings `_get`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96769
Properties can be added dynamically and not necessarily exist in the new empty instance of the Resource. So skip type check for these (there's no way to know the type in advance, and if needed check can be implemented in
_setmethod of the specificResource).Also adds missing definition for
xr/openxr/enabled.editor.