Fix single-thread builds by putting the checks on threaded builds only #97076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#96959 reverts the commit adding the issue. However, I don't see why we couldn't have this so master is functional right away. Also, sorry for that. I always wonder if I'm breaking threadless builds when dealing with the WTP. |
RandomShaper
approved these changes
Sep 16, 2024
Don't worry. You're already doing God's work. <3 |
|
Superseded by #96959. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a really
dumbnaive PR, but it could actually be the way to go.Fix for single-threaded builds. It puts the added checks by 2d1dd41 behind a check for thread-supported builds only.
Fixes #97073