Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sprite2D dialog size for smaller screen device #97199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shahriarlabib000
Copy link
Contributor

@shahriarlabib000 shahriarlabib000 commented Sep 19, 2024

So my editor scale was 180% by default

Before

Screenshot_2024-09-20-01-27-09-532_org godotengine editor v4

Now

Screenshot_2024-09-20-01-24-26-426_org godotengine editor v4 debug

@shahriarlabib000 shahriarlabib000 requested a review from a team as a code owner September 19, 2024 19:36
@WhalesState
Copy link
Contributor

WhalesState commented Sep 19, 2024

I feel like we should change window size instead of the Control's minimum size, and we leave the minimum size to be calculated automatically, to avoid such limitation.

Since if you scale the UI by 200%, you will need to make another fix to fit your screen.

@shahriarlabib000
Copy link
Contributor Author

I have no idea how to do that. Could you pls review and suggest the change pls

@shahriarlabib000
Copy link
Contributor Author

The easiest solution would be to set the minimum size height even lower 😅 (im joking)

@shahriarlabib000
Copy link
Contributor Author

shahriarlabib000 commented Sep 20, 2024

This went horribly

https://github.com/shahriarlabib000/godot/blob/3b60ec132b4cf9872b69b91a52fa2cebf2644894/editor/plugins/sprite_2d_editor_plugin.cpp#L601-#L602

	debug_uv->set_size(Size2(800, 400) * EDSCALE);
//	debug_uv->set_custom_minimum_size(Size2(800, 500) * EDSCALE);

Screenshot_2024-09-20-18-05-17-190_org godotengine editor v4 debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants