Fix C# operator *(Transform3D, Aabb)
#97208
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
added
bug
topic:dotnet
cherrypick:4.1
kleonc
commented
Sep 19, 2024
Comment on lines
-44
to
+48
| _FORCE_INLINE_ const Vector3 &operator[](int p_axis) const { | ||
| return rows[p_axis]; | ||
| _FORCE_INLINE_ const Vector3 &operator[](int p_row) const { | ||
| return rows[p_row]; | ||
| } | ||
| _FORCE_INLINE_ Vector3 &operator[](int p_axis) { | ||
| return rows[p_axis]; | ||
| _FORCE_INLINE_ Vector3 &operator[](int p_row) { | ||
| return rows[p_row]; |
There was a problem hiding this comment.
p_axis is confusing in there, AFAICT everywhere else in there axis refers to column.
kleonc
changed the title
operator *(Transform3D, AABB)operator *(Transform3D, Aabb)
aaronfranke
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current C# implemention of
static Aabb operator *(Transform3D transform, Aabb aabb)(added in #64729) is pretty-much a copy-paste of the core/C++ implementation ofAABB Transform3D::xform(const AABB &p_aabb). The issue is that such implemenation usesBasis[int]operator and:This discrepancy was not taken into account, hence incorrect calculations. This PR fixes that.
Fixes #97197.