ColorPicker: Ignore TextureRect expand mode during legacy picking #97212
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color picker has a "legacy" fallback mode when `FEATURE_SCREEN_CAPTURE` is not supported by the current `DisplayServer`. It works by "freezing" the current view by making a huge `Popup` with a `TextureRect` inside covering the screen. Before this patch, said `TextureRect` could get cut off if its buffer was nominally bigger than the parent popup, such as when the `canvas_items` content scale mode is active. This is because the default TextureRect scaling logic only allows expanding the texture up. `EXPAND_IGNORE_SIZE` fixes that by allowing the texture to logically "shrink", filling the whole screen independently of the actual buffer size. Special thanks to Federico Fausto Santoro for helping with the diagnosis :D Co-Authored-By: Federico Fausto Santoro <[email protected]>
akien-mga
changed the title
akien-mga
added
the
cherrypick:4.3
|
Shouldn't the text be inside the colored rectangle? |
|
@KoBeWi no idea, that's how it looks on |
KoBeWi
approved these changes
Oct 20, 2024
bruvzg
approved these changes
Oct 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75514
The color picker has a "legacy" fallback mode when
FEATURE_SCREEN_CAPTUREis not supported by the currentDisplayServer. It works by "freezing" the current view by making a hugePopupwith aTextureRectinside covering the screen.Before this patch, said
TextureRectcould get cut off if its buffer was nominally bigger than the parent popup, such as when thecanvas_itemscontent scale mode is active.This is because the default TextureRect scaling logic only allows expanding the texture up.
EXPAND_IGNORE_SIZEfixes that by allowing the texture to logically "shrink", filling the whole screen independently of the actual buffer size.Special thanks to @fedyfausto for helping with the diagnosis :D
Note that the preview will be blurrier than the native
canvas_itemsrendering. I think that's because the popup is re-rendering the buffer but I'm not completely sure.