Add support for print command in local (command line -d) debugger
#97218
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenqiangwang
commented
Sep 20, 2024
•
wenqiangwang
commented
- Bugsquad edit, fixes: 'print' command in command line debugger does not show anything #73389
|
This is an attempt to reopen PR #73729 after the branch deleted |
AThousandShips
changed the title
print command in local (command line -d) debugger
akien-mga
reviewed
Sep 20, 2024
Comment on lines
+431
to
+433
| List<String> names; | ||
| List<Variant> values; | ||
| debug_get_stack_level_locals(p_level, &names, &values, p_max_subitems, p_max_depth); |
There was a problem hiding this comment.
The indentation in this code is invalid, please make sure to only use tabs for indentation. You can run clang-format when committing code by setting up pre-commit with:
pip install pre-commit
pre-commit install
akien-mga
reviewed
Sep 20, 2024
Comment on lines
+435
to
+443
| Vector<String> name_vector; | ||
| for (auto it = names.begin(); it != names.end(); ++it) { | ||
| name_vector.push_back(*it); | ||
| } | ||
|
|
||
| Array value_array; | ||
| for (auto it = values.begin(); it != values.end(); ++it) { | ||
| value_array.push_back(*it); | ||
| } |
There was a problem hiding this comment.
We ban the usage of the auto keyword in the Godot codebase (with a few exceptions in complex lambdas) as we prefer the types to be explicit.
Comment on lines
+436
to
+437
| for (auto it = names.begin(); it != names.end(); ++it) { | ||
| name_vector.push_back(*it); |
There was a problem hiding this comment.
Suggested change
| for (auto it = names.begin(); it != names.end(); ++it) { | |
| name_vector.push_back(*it); | |
| for (const String &name : names) { | |
| name_vector.push_back(name); |
Use for-each syntax
Comment on lines
+441
to
+442
| for (auto it = values.begin(); it != values.end(); ++it) { | ||
| value_array.push_back(*it); |
There was a problem hiding this comment.
Suggested change
| for (auto it = values.begin(); it != values.end(); ++it) { | |
| value_array.push_back(*it); | |
| for (const Variant &value : values) { | |
| value_array.push_back(value); |
dalexeev
reviewed
Sep 20, 2024
| @@ -211,7 +211,7 @@ void LocalDebugger::debug(bool p_can_continue, bool p_is_error_breakpoint) { | |||
| if (line.get_slice_count(" ") <= 1) { | |||
There was a problem hiding this comment.
Suggested change
| if (line.get_slice_count(" ") <= 1) { | |
| if (line.find_char(' ') < 0) { |
| ScriptInstance *instance = debug_get_stack_level_instance(p_level); | ||
| if (instance) { | ||
| Variant return_val = expression.execute(value_array, instance->get_owner()); | ||
| return String(return_val); |
There was a problem hiding this comment.
I'm not familiar with the Debugger, but it might make sense to use a more useful string representation:
Suggested change
| return String(return_val); | |
| return return_val.get_construct_string(); |
| } | ||
| } | ||
|
|
||
| return ""; |
There was a problem hiding this comment.
Suggested change
| return ""; | |
| return String(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.