Add support for Android Themed Icons (monochrome) #97517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntaxerror247
changed the title
akien-mga
changed the title
|
Could you amend the commit message to be more explicit and follow our guidelines? https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind This PR's title would be a good commit message. (I'd normally do it myself but it seems like you toggled off the option that lets repo maintainers update this PR directly.) |
This comment was marked as resolved.
This comment was marked as resolved.
akien-mga
force-pushed
the
android-themed-icon
branch
from
0d86473
to
dbcc7f3
Compare
|
Thanks, updated :) |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Nice! @syntaxerror247 thanks for implement it! 👏 |
akien-mga
added
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Android Themed icons.
Closes godotengine/godot-proposals#5572
demo.mp4