-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove note about missing per-vertex-shading #97917
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a note that needs to be removed in BaseMaterial3D:
doc/classes/BaseMaterial3D.xml:
352 Sets whether the shading takes place, per-pixel, per-vertex or unshaded. Per-vertex lighting is faster, making it the best choice for mobile applications, however it looks considerably worse than per-pixel. Unshaded rendering is the fastest, but disables all interactions with lights.
353: [b]Note:[/b] Setting the shading mode vertex shading currently has no effect, as vertex shading is not implemented yet.
354 </member>
Nice catch! 👍 |
Changes look good to me. The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that. |
And please update your commit message to be more descriptive, the title of the PR would be appropriate, using |
72fa47f
to
e994c49
Compare
Thank you both for the suggestions. I didn't expect the rebase to be that easy (instead of |
Followup to #83360