Restore arc_tolerance
value when using Clipper2's InflatePaths
#98017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed when upgrading from Clipper to Clipper2.
The value used to be passed as the second argument to the ClipperOffset constructor here (with an inaccurate/outdated comment, as the default is
0.25
unscaled):godot/core/math/geometry_2d.cpp
Line 293 in a8bc9f3
Now we set the same parameter in Clipper2 by passing it to
InflatePaths
.The MRP now yields results and timings of the same order of magnitude as with Clipper in 4.2.2: