Fix slow lightmap texture import by disabling VRAM compression for it #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases memory usage when using LightmapGI, but it also improves lightmap appearance.
akien-mga
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
I confirm that the initial import is pretty slow, took several minutes before I saw any progress beyond 0%.
It did work in the end, but if this makes it significantly faster and costs around 100MB VRAM on an another relatively small demo, that might be ok. I don't know what's our VRAM budget though, would be good to have input from @clayjohn.
Also needs rebase.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases memory usage when using LightmapGI, but it also improves lightmap appearance.