feat: simplify and improve rpc TCP listener #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use tokio bind function to simplify code and set SO_REUSEADDR. This also causes the socket to use a bigger listen backlog of 1024 (mio default) instead of 128. And this supports IPv6. * Set TCP keepalive interval and count too, because the default (75 seconds, 9) is not ideal either. * Set TCP_NODELAY. Disabling Nagle's algorithm is usually the better default.
zeroqn
approved these changes
Mar 22, 2022
jjyr
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use tokio bind function to simplify code and set
SO_REUSEADDR. Thisalso causes the socket to use a bigger listen backlog of 1024 (mio
default) instead of 128. And this supports IPv6.
Set TCP keepalive interval and count too, because the default (75
seconds, 9) is not ideal either.
Set
TCP_NODELAY. Disabling Nagle's algorithm is usually the betterdefault.