Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update Life of a Polyjuice Transaction #630

Merged
merged 2 commits into from
Apr 1, 2022
Merged

docs: update Life of a Polyjuice Transaction #630

merged 2 commits into from
Apr 1, 2022

Conversation

Flouse
Copy link
Collaborator

@Flouse Flouse commented Mar 25, 2022 •
edited
Loading

Rename pETH to pCKB

Why

  • Developers and users feel confusing between pETH and ETH. Some of them thought that pETH is the real ETH.
  • By default, we use CKB as pCKB in Polyjuice. CKB has 8 decimals while Ether has 18 decimals.

    Shannon is a fractional denomination of CKBytes. One CKByte is equal to 100,000,000 Shannons.

I think the name pCKB is more clearer.

@Flouse Flouse requested review from jjyr and janx March 26, 2022 07:42
@Flouse Flouse force-pushed the docs branch 2 times, most recently from 0a5cd8b to 2a4bd41 Compare March 27, 2022 15:22
@Flouse Flouse changed the base branch from compatibility-breaking-changes to fix-producer.account_id March 27, 2022 15:23
Base automatically changed from fix-producer.account_id to compatibility-breaking-changes March 28, 2022 04:10
@jjyr
Copy link
Collaborator

jjyr commented Mar 28, 2022 •
edited
Loading

Pls use another PR to submit code changes.

IMO we can use layer2-CKB to reference to the layer2 assets. Yokaiswap and other layer2 Dapps still use CKB as the symbol, so if we introduce pCKB in this documentation it may confuse users.

@Flouse
Copy link
Collaborator Author

Flouse commented Mar 28, 2022 •
edited
Loading

Pls use another PR to submit code changes.

other code changes were removed.

@Flouse Flouse marked this pull request as ready for review March 28, 2022 06:37
@janx
Copy link

janx commented Mar 31, 2022

pCKB and layer2-CKB are similar semantically, with different prefixes. I think pCKB is better because its prefix is shorter, and layer2- refers to a much broader concept than Godwoken.

No matter it's pCKB or xyzCKB, it should be considered code name not display name. The applications should feel free to display CKB as token name on UI wherever it's pCKB behind.

Another option is to follow forcebridge's convention, use CKB|ckb as symbol (code name).

@Flouse Flouse merged commit 4e0fcf3 into compatibility-breaking-changes Apr 1, 2022
@Flouse Flouse deleted the docs branch April 1, 2022 07:25
Flouse added a commit to godwokenrises/godwoken-polyjuice that referenced this pull request Apr 4, 2022
@Flouse
docs: rename pETH to pCKB
e7ca13b 
Ref:
- godwokenrises/godwoken#630
Flouse added a commit to godwokenrises/godwoken-polyjuice that referenced this pull request Apr 6, 2022
@Flouse
docs: rename pETH to pCKB
bc867b9 
Ref:
- godwokenrises/godwoken#630
@Flouse Flouse mentioned this pull request Apr 6, 2022
Merged
Flouse added a commit to godwokenrises/godwoken-polyjuice that referenced this pull request Apr 8, 2022
@Flouse
docs: update some links and rename pETH to pCKB (#141)
5f6e340 
* docs: update some links

* docs: rename pETH to pCKB

Ref:
- godwokenrises/godwoken#630
Flouse added a commit to godwokenrises/godwoken-polyjuice that referenced this pull request Apr 14, 2022
@Flouse
docs: update some links and rename pETH to pCKB (#141)
d230446 
* docs: update some links

* docs: rename pETH to pCKB

Ref:
- godwokenrises/godwoken#630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyr jjyr jjyr approved these changes

@janx janx Awaiting requested review from janx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Flouse @jjyr @janx