BREAKING CHANGE: change ckb decimal to 18 #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroqn
force-pushed
the
feat-change-ckb-decimal-to-18
branch
3 times, most recently
from
8b67bda
to
9597b6d
Compare
zeroqn
force-pushed
the
feat-change-ckb-decimal-to-18
branch
from
9597b6d
to
8950ef4
Compare
zeroqn
force-pushed
the
feat-change-ckb-decimal-to-18
branch
2 times, most recently
from
99412c8
to
afc4c7a
Compare
zeroqn
force-pushed
the
feat-change-ckb-decimal-to-18
branch
from
a9ece23
to
08f3fab
Compare
magicalne
reviewed
Apr 28, 2022
blckngm
reviewed
Apr 28, 2022
blckngm
reviewed
Apr 29, 2022
|
We should also change |
zeroqn
force-pushed
the
feat-change-ckb-decimal-to-18
branch
from
4ab866c
to
8d32a46
Compare
Flouse
requested changes
Apr 29, 2022
Flouse
previously approved these changes
Apr 29, 2022
Flouse
previously approved these changes
May 5, 2022
zeroqn
force-pushed
the
feat-change-ckb-decimal-to-18
branch
from
72dd582
to
fb6a073
Compare
Flouse
previously approved these changes
May 5, 2022
keroro520
suggested changes
May 5, 2022
jjyr
previously approved these changes
May 5, 2022
CHANGELOG.md
Outdated
| @@ -19,6 +19,8 @@ In the new version, we improve the compatibility of Godwoken: | |||
| - Support Ethereum signature format and EIP-712. User can view the transaction before signing, instead of signing a random 32 bytes message. [#561](https://github.com/nervosnetwork/godwoken/pull/561) | |||
| - Fix the total supply interface of sUDT ERC-20 proxy contract [#560](https://github.com/nervosnetwork/godwoken/pull/560) | |||
| - Support interactive with eth address that haven't been registered to Godwoken. | |||
| - Unify layer 2 fungible token represatation as uint256. | |||
| - Change layer 2 ckb decimal from 8 to 18, improve compatibility between metamask and native ckb. [#675](https://github.com/nervosnetwork/godwoken/pull/675) | |||
|
|
|||
| In short, as a developer, you can use Godwoken v1 just like anyother Ethereum compatible chain, all you need to do is to switch the network to Godwoken. The polyjuice-provider web3 plugin is removed in the v1 version. | |||
There was a problem hiding this comment.
In short, developers can use Godwoken v1 the same way as other ethereum compatible chains, all that has to be done is to switch the network to Godwoken. The polyjuice-provider web3 plugin has been removed in v1.
keroro520
reviewed
May 5, 2022
keroro520
previously approved these changes
May 5, 2022
Flouse
previously approved these changes
May 5, 2022
keroro520
previously approved these changes
May 6, 2022
jjyr
approved these changes
May 7, 2022
Flouse
approved these changes
May 7, 2022
keroro520
added a commit
to keroro520/godwoken-examples
that referenced
this pull request
May 11, 2022
Why: godwokenrises/godwoken#675 change the precision of units. How: Adjust the molecule types New types definition: https://github.com/zeroqn/godwoken/blob/e5add779d0f5a5b460e3154859880fab8906f21f/crates/types/schemas/godwoken.mol ``` moleculec --language - --schema-file godwoken.mol --format json moleculec-es -inputFile 1.json -outputFile generated.js -generateTypeScriptDefinition ./node_modules/.bin/babel --plugins @babel/plugin-transform-modules-commonjs src/schema/generated.js ``` Tags:
Flouse
added a commit
to Flouse/godwoken-docker-prebuilds
that referenced
this pull request
Jun 6, 2022
godwoken - godwokenrises/godwoken#675 godwoken-scripts - godwokenrises/godwoken-scripts#118 godowken-polyjuice - godwokenrises/godwoken-polyjuice#146 godowken-tests - godwokenrises/godwoken-tests#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR unified layer2 fungible token representation as u256.
This PR also changes the decimal of CKB, in layer1 CKB is represented in 8 decimal, but when user deposit CKB into layer2, we changed the representation to 18 decimal. Thus, layer2 CKB can play the same role as ETH, developers can operate CKB as 18 decimal asset(like ETH) in their contract without modification. This change also improve the compatibility between Metamask and the native token CKB.