Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use mem pool state for “get block” RPCs #742

Merged
merged 1 commit into from
Jun 29, 2022
Merged

fix: use mem pool state for “get block” RPCs #742

merged 1 commit into from
Jun 29, 2022

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Jun 22, 2022

Mem pool state can fall behind db state on read only nodes with P2P mem
pool syncing due to separate reset and refresh_mem_pool calls.

This PR changes RPC to only return blocks that are in the mem pool
state so that blocks and other state remain consistent.

@blckngm
fix: use mem pool state for “get block” RPCs
7fbfd01 
Mem pool state can fall behind db state on read only nodes with P2P mem
pool syncing due to separate `reset` and `refresh_mem_pool` calls.

This commit changes RPC to only return blocks that are in the mem pool
state so that blocks and other state remain consistent.
@blckngm blckngm requested a review from jjyr June 22, 2022 02:33
@gw-bot
Copy link

gw-bot bot commented Jun 22, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2539482391

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@Flouse Flouse requested a review from magicalne June 27, 2022 07:14
@jjyr jjyr merged commit 8b5badd into godwokenrises:develop Jun 29, 2022
@blckngm blckngm deleted the fix-readonly-rpc-state branch June 29, 2022 07:15
@blckngm blckngm mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicalne magicalne magicalne approved these changes

@zeroqn zeroqn zeroqn approved these changes

@jjyr jjyr Awaiting requested review from jjyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blckngm @magicalne @zeroqn @jjyr