fix: always refresh pending deposit cells #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jjyr
force-pushed
the
feat-always-refresh-deposit
branch
from
deec6c4
to
19feeb5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Running integration testWorkflow Run Id: 2616023882 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
zeroqn
previously approved these changes
Jul 7, 2022
keroro520
previously approved these changes
Jul 8, 2022
Flouse
reviewed
Jul 8, 2022
Flouse
previously approved these changes
Jul 8, 2022
Co-authored-by: Flouse <[email protected]>
Running integration testWorkflow Run Id: 2634921624 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
refresh_deposit_cellsfunction is introduced in the #433 , the original intension is to keep consistent ofaccount idduring the mem-pool refreshing, otherwise, the following txs will invalid due to the incorrect signature.In the v1 version, we migrate signing method to the Ethereum & EIP-712, the
account idis not included in the signature anymore, even theaccount idis changed, the following txs still passes the validate.