Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recover sender of non EIP-155 txs #790

Merged

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Aug 24, 2022

@gw-bot
Copy link

gw-bot bot commented Aug 24, 2022

Running integration test

Workflow Run Id: 2918585762

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@keroro520
Copy link
Contributor

keroro520 commented Aug 25, 2022

Which part of code recovers the sender of non EIP-155 txs? @jjyr

@zeroqn
Copy link
Contributor

zeroqn commented Aug 26, 2022

Which part of code recovers the sender of non EIP-155 txs? @jjyr

Only hash six rlp encoded items of tx for signing message

https://github.com/nervosnetwork/godwoken/blob/6c4352d37233539b90403071fdd642a6cc6c808b/crates/generator/src/account_lock_manage/secp256k1.rs#L271-L276

@keroro520
Copy link
Contributor

Which part of code recovers the sender of non EIP-155 txs? @jjyr

Only hash six rlp encoded items of tx for signing message

https://github.com/nervosnetwork/godwoken/blob/6c4352d37233539b90403071fdd642a6cc6c808b/crates/generator/src/account_lock_manage/secp256k1.rs#L271-L276

Thanks a lot!

@jjyr jjyr merged commit c4cd39e into godwokenrises:develop Aug 29, 2022
@jjyr jjyr deleted the fix-recover-sender-of-non-EIP-155-tx branch August 29, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants