feat: support non-x86 build #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to check this in CI? Don't know how ready the github hosted M1 runners are, but we can always |
jjyr
force-pushed
the
support-m1-build
branch
from
53263e4
to
762e2df
Compare
I will make the change of CI in another PR. It is painful to get it run correctly... |
blckngm
reviewed
Nov 30, 2022
blckngm
reviewed
Nov 30, 2022
blckngm
previously approved these changes
Nov 30, 2022
keroro520
previously approved these changes
Nov 30, 2022
This was referenced Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ckb-vm 0.22.0.ckb-vm-aotto enable the AOT feature on x86.ckb-sdkcrate. It contains too many dependencies that may conflict with Godwoken's dependencies, and we want to make the dependencies minimal, so we copy what we need from the repo.