feat!: use delegate cell lock as rollup cell lock #940
Conversation
|
Some gw-tools args have changed, see kicker PR:
Edit: no, need to modify |
blckngm
force-pushed
the
dev-delegate-cell-lock
branch
2 times, most recently
from
60af8fb
to
5439a33
Compare
blckngm
force-pushed
the
dev-delegate-cell-lock
branch
2 times, most recently
from
8160759
to
c36937f
Compare
| } | ||
|
|
||
| // Get expected type hash from args. | ||
| let expected_type_hash: [u8; 32] = args.try_into().map_err(|_| Error::InvalidArgs)?; |
There was a problem hiding this comment.
It might be better when args can be longer than 32 bytes. Better for upgrading.
There was a problem hiding this comment.
What is expected to be upgraded here? It's unlikely that the length of “type hash” will change.
| .position(|type_hash| type_hash == Some(expected_type_hash)) | ||
| .ok_or(Error::CellDepNotFound)?; | ||
| let data = load_cell_data(cell_dep_idx, Source::CellDep)?; | ||
| let expected_lock_hash_160: [u8; 20] = |
There was a problem hiding this comment.
How about requiring this data to:
- has a length >= 20
- and is a prefix of the lock hash
There was a problem hiding this comment.
IMO it is fair enough to take the first 20 bytes. There is no benefit to accepting a variant length lock hash.
| let args = script.as_reader().args().raw_data(); | ||
|
|
||
| let witness_arg = load_witness_args(0, Source::GroupInput)?; | ||
| if witness_arg.as_reader().lock().is_some() { |
There was a problem hiding this comment.
This is discussed in the internal issue. If we delegate to e.g. secp256k1/blake160, the witnesses of this lock will not be checked by it, so we added some basic sanity checks on the first witness arg.
blckngm
force-pushed
the
dev-delegate-cell-lock
branch
from
655763d
to
a4d54ca
Compare
blckngm
force-pushed
the
dev-delegate-cell-lock
branch
from
3abb5fe
to
205b107
Compare
jjyr
requested review from
XuJiandong,
jjyr and
zeroqn
and removed request for
XuJiandong
|
@sopium please resolve conflicts |
blckngm
force-pushed
the
dev-delegate-cell-lock
branch
from
205b107
to
69a5f0d
Compare
Use delegate cell lock to support managing block producer key via e.g. multisig lock.
Delegate cell lock is a simple lock that delegates verification to another lock via a “delegate cell”. Delegate cell can be managed separately by e.g. a multisig lock.