feat: automatically adjust fee rate #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flouse
requested changes
Mar 21, 2023
magicalne
previously approved these changes
Mar 22, 2023
and automatically reset submission txs when a block cannot be confirmed for an extended period of time.
jjyr
approved these changes
Mar 24, 2023
magicalne
approved these changes
Mar 24, 2023
Flouse
approved these changes
Mar 24, 2023
Flouse
reviewed
Mar 24, 2023
Flouse
reviewed
Mar 27, 2023
| @@ -180,14 +181,25 @@ pub struct PscConfig { | |||
| pub submitted_limit: u64, | |||
| /// Minimum delay between blocks. Default is 8 seconds. | |||
| pub block_interval_secs: u64, | |||
| pub min_fee_rate: u64, | |||
| pub max_fee_rate: u64, | |||
| pub fee_rate_pid: Option<Pid<f64>>, | |||
There was a problem hiding this comment.
Do you have a tested config example for fee_rate_pid?
@sopium
There was a problem hiding this comment.
The sim program outputs PID params on exit, e.g.:
setpoint = 0.6
output_limit = 1.0
kp = -0.8
ki = -0.08
kd = 0.0
p_limit = 1.0
i_limit = 1.0
d_limit = 0.0
integral_term = -1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and automatically reset submission txs when a block cannot be confirmed for an extended period of time.
Manually tested by altering ckb-miner parameters in kicker.