-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to OTEL-Go v1.14.0 #499
Conversation
Bumps [go.opentelemetry.io/otel/metric](https://github.com/open-telemetry/opentelemetry-go) from 0.36.0 to 0.37.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@metric/v0.36.0...metric/v0.37.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/metric dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
does this mean that it is a breaking change and we should upgrade the major version of the package ? |
Depends on how you would consider it. So I would say it isn't a breaking change to this package. But users need to use otel-go 1.14.0. You can read the changelog of this release, v1.14.0 Sorry, I should have written a more detailed description to this PR. |
The specific breaking changes from the Otel-go package (v1.14.0) that I adapted are:
The otelfiber.Middleware interface did not change. |
this is enough to know 👍 |
Hi, do we expect anything else on this PR? |
OpenTelemetry-Go did change the sigature for the metric.Reader interface.
They also deprecated the Unit interface in favor of a string.
To keep using otelfiber with the latest otel-go packages we need to replace the Unit struct with string constants.
I also adapted the call signature of the reader interface like it is shown in the libraries tests.