-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making Websocket Local read-write #676
Conversation
Thanks for that, can you add the signatures to the readme like the other middlewares? https://github.com/gofiber/contrib/tree/main/swagger#signatures |
This should wait for #669 so we can test it |
@supagroova can you pls update your branch with the upstream master |
@supagroova friendly ping |
@ReneWerner87 I took care of the merge conflict, do we need another unit-test for these changes? and the README changes. |
yes would be good |
I honestly have no idea how to test this, maybe @mstrYoda can help with this unit-test |
Well I think adding the new if condition as a test scenario to here works well: https://github.com/gofiber/contrib/blob/main/websocket/websocket_test.go#L224 |
I was going to add tests, then i realize i have no idea how to test this 😂 |
Well I will add test for this function no worry, we can merge this PR 👍 |
Fixes #675