🐛 bug: fix route naming issue when using same path for different methods

gofiber · Oct 21, 2023 · 1dc9a5e · 1dc9a5e
1 parent 37ad7c7
commit 1dc9a5e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/app.go b/app.go
@@ -620,7 +620,11 @@ func (app *App) Name(name string) Router {
 
 	for _, routes := range app.stack {
 		for _, route := range routes {
-			if route.Path == app.latestRoute.Path {
+			isMethodValid := route.Method == app.latestRoute.Method || app.latestRoute.use ||
+				(app.latestRoute.Method == MethodGet && route.Method == MethodHead)
+
+			if route.Path == app.latestRoute.Path && isMethodValid {
+
 				route.Name = name
 
 				if route.group != nil {

diff --git a/app_test.go b/app_test.go
@@ -1859,7 +1859,7 @@ func Test_Middleware_Route_Naming_With_Use(t *testing.T) {
 	}
 }
 
-func Test_Route_Naming_Issue_2671(t *testing.T) {
+func Test_Route_Naming_Issue_2671_2685(t *testing.T) {
 	app := New()
 
 	app.Get("/", emptyHandler).Name("index")
@@ -1904,4 +1904,22 @@ func Test_Route_Naming_Issue_2671(t *testing.T) {
 
 	postGroup.Post("", emptyHandler).Name("post.update")
 	utils.AssertEqual(t, "/post/:postId", app.GetRoute("post.update").Path)
+
+	app.Get("/users", nil).Name("get-users")
+	app.Post("/users", nil).Name("add-user")
+	getUsers := app.GetRoute("get-users")
+	utils.AssertEqual(t, getUsers.Path, "/users")
+
+	addUser := app.GetRoute("add-user")
+	utils.AssertEqual(t, addUser.Path, "/users")
+
+	newGrp := app.Group("/name-test")
+
+	newGrp.Get("/users", nil).Name("get-users")
+	newGrp.Post("/users", nil).Name("add-user")
+	getUsers = app.GetRoute("get-users")
+	utils.AssertEqual(t, getUsers.Path, "/users")
+
+	addUser = app.GetRoute("add-user")
+	utils.AssertEqual(t, addUser.Path, "/users")
 }