♻️ Refactor: Remove redundant nil check (#2584)

From the Go docs: "If the map is nil, the number of iterations is 0." [1] Therefore, an additional nil check for before the loop is unnecessary. [1]: https://go.dev/ref/spec#For_range Signed-off-by: Eng Zer Jun <[email protected]>
gofiber · Aug 17, 2023 · 242ff94 · 242ff94 · ReneWerner87 · Aug 17, 2023
1 parent 85d1f68
commit 242ff94
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/middleware/cache/cache.go b/middleware/cache/cache.go
@@ -141,10 +141,8 @@ func New(config ...Config) fiber.Handler {
 			if len(e.cencoding) > 0 {
 				c.Response().Header.SetBytesV(fiber.HeaderContentEncoding, e.cencoding)
 			}
-			if e.headers != nil {
-				for k, v := range e.headers {
-					c.Response().Header.SetBytesV(k, v)
-				}
+			for k, v := range e.headers {
+				c.Response().Header.SetBytesV(k, v)
 			}
 			// Set Cache-Control header if enabled
 			if cfg.CacheControl {

diff --git a/middleware/logger/tags.go b/middleware/logger/tags.go
@@ -199,10 +199,8 @@ func createTagMap(cfg *Config) map[string]LogFunc {
 		},
 	}
 	// merge with custom tags from user
-	if cfg.CustomTags != nil {
-		for k, v := range cfg.CustomTags {
-			tagFunctions[k] = v
-		}
+	for k, v := range cfg.CustomTags {
+		tagFunctions[k] = v
 	}
 
 	return tagFunctions