-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
v3: Refactor Benchmark Results Workflow (#3082)
* Refactor benchmarks workflow * Use full semver tag * Add fetch depth
- Loading branch information
Showing
1 changed file
with
69 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,13 +9,21 @@ on: | |
paths-ignore: | ||
- "**/*.md" | ||
|
||
permissions: | ||
# deployments permission to deploy GitHub pages website | ||
deployments: write | ||
# contents permission to update benchmark contents in gh-pages branch | ||
contents: write | ||
|
||
name: Benchmark | ||
jobs: | ||
Compare: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Fetch Repository | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # to be able to retrieve the last commit in main | ||
|
||
- name: Install Go | ||
uses: actions/setup-go@v5 | ||
|
@@ -26,24 +34,75 @@ jobs: | |
- name: Run Benchmark | ||
run: set -o pipefail; go test ./... -benchmem -run=^$ -bench . | tee output.txt | ||
|
||
- name: Get Previous Benchmark Results | ||
uses: actions/cache@v4 | ||
# NOTE: Benchmarks could change with different CPU types | ||
- name: Get GitHub Runner System Information | ||
uses: kenchan0130/[email protected] | ||
id: system-info | ||
|
||
- name: Get Main branch SHA | ||
id: get-main-branch-sha | ||
run: | | ||
SHA=$(git rev-parse origin/main) | ||
echo "sha=$SHA" >> $GITHUB_OUTPUT | ||
- name: Get Benchmark Results from main branch | ||
id: cache | ||
uses: actions/cache/restore@v4 | ||
with: | ||
path: ./cache | ||
key: ${{ runner.os }}-benchmark | ||
key: ${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-${{ steps.system-info.outputs.cpu-model }}-benchmark | ||
|
||
# This will only run if we have Benchmark Results from main branch | ||
- name: Compare PR Benchmark Results with main branch | ||
uses: benchmark-action/[email protected] | ||
if: steps.cache.outputs.cache-hit == 'true' | ||
with: | ||
tool: 'go' | ||
output-file-path: output.txt | ||
external-data-json-path: ./cache/benchmark-data.json | ||
# Do not save the data (This allows comparing benchmarks) | ||
save-data-file: false | ||
fail-on-alert: true | ||
comment-on-alert: true | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
summary-always: true | ||
alert-threshold: "150%" | ||
|
||
- name: Save Benchmark Results | ||
- name: Store Benchmark Results for main branch | ||
uses: benchmark-action/[email protected] | ||
if: ${{ github.ref_name == 'main' }} | ||
with: | ||
tool: "go" | ||
tool: 'go' | ||
output-file-path: output.txt | ||
external-data-json-path: ./cache/benchmark-data.json | ||
# Save the data to external file (cache) | ||
save-data-file: true | ||
fail-on-alert: true | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
summary-always: true | ||
alert-threshold: "150%" | ||
|
||
- name: Publish Benchmark Results to GitHub Pages | ||
uses: benchmark-action/[email protected] | ||
if: ${{ github.ref_name == 'main' }} | ||
with: | ||
tool: 'go' | ||
output-file-path: output.txt | ||
github-token: ${{ secrets.BENCHMARK_TOKEN }} | ||
benchmark-data-dir-path: "benchmarks" | ||
fail-on-alert: true | ||
comment-on-alert: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} | ||
# Enable Job Summary for PRs - deactivated because of issues | ||
#summary-always: ${{ github.event_name != 'push' && github.event_name != 'workflow_dispatch' }} | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
comment-on-alert: true | ||
summary-always: true | ||
# Save the data to external file (GitHub Pages) | ||
save-data-file: true | ||
alert-threshold: "150%" | ||
# TODO: reactivate it later -> when v3 is the stable one | ||
#auto-push: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} | ||
auto-push: false | ||
save-data-file: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} | ||
|
||
- name: Update Benchmark Results cache | ||
uses: actions/cache/save@v4 | ||
if: ${{ github.ref_name == 'main' }} | ||
with: | ||
path: ./cache | ||
key: ${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-${{ steps.system-info.outputs.cpu-model }}-benchmark |
9c0cb9d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
1.50
.Benchmark_Utils_GetOffer/1_parameter
215.7
ns/op 0 B/op 0 allocs/op137
ns/op 0 B/op 0 allocs/op1.57
Benchmark_CORS_NewHandlerPreflightSingleOrigin
1152
ns/op 104 B/op 5 allocs/op758.5
ns/op 0 B/op 0 allocs/op1.52
Benchmark_CORS_NewHandlerPreflightWildcard
1058
ns/op 104 B/op 5 allocs/op697.1
ns/op 0 B/op 0 allocs/op1.52
This comment was automatically generated by workflow using github-action-benchmark.