-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix(middleware/logger): default latency output format #2580
🐛 fix(middleware/logger): default latency output format #2580
Conversation
Any ideas why the CI is failing? |
@gaby windows VM is slow. === CONT Test_Logger_WithLatency_DefaultFormat
logger_test.go:303:
Test: Test_Logger_WithLatency_DefaultFormat
Trace: logger_test.go:303
Description: Expected latency to be in µs, got 1.5727ms
Expect: false (bool)
Result: true (bool)
=== CONT Test_Logger_WithLatency
logger_test.go:251:
Test: Test_Logger_WithLatency
Trace: logger_test.go:251
Description: Expected latency to be in µs, got 1.5727ms
Expect: false (bool)
Result: true (bool)
--- FAIL: Test_Logger_WithLatency_DefaultFormat (0.00s) |
@sixcolors I wonder if removing |
Trying to make windows CI pass....
@gaby could be related to golang/go#29485 |
Yeah, may need to update the tests then |
Unrelated MacOS failure this time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
fixes middleware/logger default latency output format to match TagLatency
Fixes #2561
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/