Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable ws lives #1

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Configurable ws lives #1

wants to merge 4 commits into from

Conversation

dkarella
Copy link

@dkarella dkarella commented Mar 16, 2023

What does this PR do?

This PR adds a couple of changes for us to be able to test using WebSockets as the only transport mechanism without risk of falling into the unrecoverable "failed" state, and to gather more information about why and how often the connections drop to the fallback transport.

This change will more than likely not make it back into the official pusher-js repo, it's just meant for us to quickly test. As such, we should not merge this PR – it's just here for reviewing. Depending on what we find, a more flushed out change may come later.

Checklist

  • All new functionality has tests.
  • All tests are passing.
  • New or changed API methods have been documented.
  • npm run format has been run

CHANGELOG

  • [CHANGED] made WebSocket lives configurable for the user
  • [ADDED] optional reportDeathCallback to allow users to get information about why a transport mechanism lost a life
  • [CHANGED] changed name of package to @goguardian/pusher-js

allows user of the library to get information about why a connection lost a life
It's sent as a query parameter in requests to Pusher.
@SidneyNemzer SidneyNemzer marked this pull request as draft July 25, 2023 15:21
@SidneyNemzer
Copy link

Converted to draft as we do not intend to merge this (see description)

@SidneyNemzer SidneyNemzer self-assigned this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants