Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum to core/jobservice secrets in adminserver #116

Merged

Conversation

jchanam
Copy link
Contributor

@jchanam jchanam commented Dec 11, 2018

Adminserver is reading the core and jobservice secrets:

- name: CORE_SECRET
valueFrom:
secretKeyRef:
name: {{ template "harbor.core" . }}
key: secret
- name: JOBSERVICE_SECRET
valueFrom:
secretKeyRef:
name: "{{ template "harbor.jobservice" . }}"
key: secret

Add checksum to secrets of core and jobservice to force restart of adminserver if any of those secret value changes.

Fixes partially #115

@jchanam jchanam force-pushed the fix-adminserver-checksum-core-secret branch from 3536942 to a0444fa Compare December 11, 2018 10:12
@ywk253100
Copy link
Collaborator

@jchanam Thanks.

@ywk253100 ywk253100 merged commit 32f927f into goharbor:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants