Add registryctl env secretRef for S3 existingSecret #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If s3.existingSecret has been set, ensure the there is an envFrom secretRef for the registryctl container Signed-off-by: Ian <[email protected]>
pyratm
force-pushed
the
registryctl-envfrom-s3-secret
branch
from
a998337
to
6fa51ad
Compare
zyyw
approved these changes
Jul 27, 2023
ywk253100
approved these changes
Aug 24, 2023
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
persistence.imageChartStorage.s3.existingSecrethas been set, ensure the there is an envFrom secretRef for theregistryctlcontainer. This is already applied to theregistrycontainer.Without this change when an existing S3 secret is used, garbage collection on an S3 bucket fails to successfully delete any blobs because the
registryctlcontainer has no valid S3 Auth available to it.The result of this issue is an ever growing S3 bucket that Harbor does not track because it has removed knowledge of the manifests/blobs during GC.