feat: core service ready/liveness probes to be configurable #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhitt
force-pushed
the
chore/configurable-core-probes
branch
2 times, most recently
from
e25b61f
to
72ff59f
Compare
Signed-off-by: dylanhitt <[email protected]>
dylanhitt
force-pushed
the
chore/configurable-core-probes
branch
from
72ff59f
to
369d695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for core probes to be configurable. I understand most operations should take less than 1 second and they seem too. However there's points where I've found especially when using the AWS VPC CNI. The probe takes greater than a second, it's extremely hard to prove exactly why. However, when I patch the timeoutSeconds to 10 seconds the 503s caused by the readiness probe failing go away.
I've noticed people have asked for this and have been shot down. I'm hoping a PR is better received.
Cheers