Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Katex error handling #12748

Closed
bep opened this issue Aug 11, 2024 · 1 comment · Fixed by #12749
Closed

Improve Katex error handling #12748

bep opened this issue Aug 11, 2024 · 1 comment · Fixed by #12749
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.132.0

Comments

@bep
Copy link
Member

bep commented Aug 11, 2024

Most specific, it doesn't seem that errors thrown in JS when invoking the RPC commands is correctly passed up to the client.
@bep bep added this to the v0.132.0 milestone Aug 11, 2024
@bep bep self-assigned this Aug 11, 2024
bep added a commit to bep/hugo that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling
003e0bf 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes gohugoio#12748
@bep bep mentioned this issue Aug 12, 2024
Merged
bep added a commit to bep/hugo that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling
65e5133 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes gohugoio#12748
bep added a commit to bep/hugo that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling
f7a9a77 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes gohugoio#12748
bep added a commit to bep/hugo that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling
f0237bf 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes gohugoio#12748
bep added a commit to bep/hugo that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling and fix handling of large expressions
617ea9a 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes gohugoio#12748
bep added a commit to bep/hugo that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling and fix handling of large expressions
184e0b7 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes gohugoio#12748
bep added a commit to bep/hugo that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling and fix handling of large expressions
4a1ba4d 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes gohugoio#12748
bep added a commit that referenced this issue Aug 12, 2024
@bep
Improve Katex error handling and fix handling of large expressions
e1e1baa 
* Make throwOnError=true the new default
* Handle JS errors as part of the RPC request/response flow
* Return a new Result type with .Err on it

This enables constructs on the form:

```handlebars
{{ with transform.ToMath "c = \\foo{a^2 + b^2}" }}
	{{ with .Err }}
	 	{{ warnf "error: %s" . }}
	{{ else }}
		{{ . }}
	{{ end }}
{{ end }}
```

Note that the new `Result` type behaves like `template.HTML` (or a string if needed) when printed, but it will panic if in a error state.

Closes #12748
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.132.0
Development

Successfully merging a pull request may close this issue.

Improve Katex error handling bep/hugo
1 participant
@bep