Add support for backslash escaping in url and permalinks #12938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
reviewed
Oct 14, 2024
n1xx1
force-pushed
the
fix-permalink-ill-formed
branch
from
543a430
to
217bf7c
Compare
n1xx1
changed the title
2 tasks
bep
force-pushed
the
fix-permalink-ill-formed
branch
3 times, most recently
from
dfc51d1
to
3bbe9fc
Compare
Mostly to get back to an attribute regexp that's reasonably simle to read/understand. Updates gohugoio#12918
bep
force-pushed
the
fix-permalink-ill-formed
branch
from
3bbe9fc
to
d068ddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12918. I didn't improve the error handling because the go date formatting tokens are supported. If you have something like
:example1it would be a valid format since 1 is the number of the month. I think leaving the invalid token error as is is better.