-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only lookup storage specs that we actually need #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tims
force-pushed
the
selectivestoragespecs
branch
from
January 8, 2019 14:09
32b4c2e
to
3d6f1ca
Compare
zhilingc
reviewed
Jan 8, 2019
ingestion/src/test/java/feast/ingestion/service/CompositeSpecService.java
Outdated
Show resolved
Hide resolved
tims
force-pushed
the
selectivestoragespecs
branch
from
January 9, 2019 06:31
3d6f1ca
to
4a9d751
Compare
…he split main output, so they can be written downstream (eg to the warehouse)
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yanson
pushed a commit
to Yanson/feast
that referenced
this pull request
Jul 29, 2020
Cherry-picked upstream PR feast-dev#769 Changed WASB implementation of Azure file staging to ABFSS to support directory file enumeration, for retrieving Spark job output (collection of files) in feast-dev#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
It does some hack with the errors store spec, which we will ultimately remove when we don't get that from core.