Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't tag a file path that contains colon. #857

Closed
amano-kenji opened this issue Jun 19, 2022 · 3 comments
Closed

I can't tag a file path that contains colon. #857

amano-kenji opened this issue Jun 19, 2022 · 3 comments

Comments

@amano-kenji
Copy link

amano-kenji commented Jun 19, 2022

For example, try to tag /home/user/abc:abc.txt or /home/user/dir:1/file.txt by pressing t on it. You can't.

I just read ~/.local/share/lf/tags, and colon is used as a separator in that file. Perhaps, tags file should become a JSON file?

Or, the parser should use the last colon as the separator between a tag and a file path?

@amano-kenji
Copy link
Author

lf/nav.go

Line 1670 in 36a7a18

toks := strings.SplitN(scanner.Text(), ":", 2)
causes the issue.

gokcehan added a commit that referenced this issue Jun 26, 2022
@gokcehan
Copy link
Owner

@amano-kenji Sorry for late reply. Thanks for reporting and locating the issue. I have now pushed a fix to handle colons in paths for tags.

laktak pushed a commit to laktak/lf that referenced this issue Jul 2, 2022
@amano-kenji
Copy link
Author

I tested the latest commit. The issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants