Fix statusbar spacing #1205
Merged
Fix statusbar spacing #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #1168 had been merged recently so I decided to try it out.
While the different components can be customised, I noticed that the spacing between them sometimes have issues because they stilll follow the previous implementation where the statusbar contents were fixed. For example with
set ruler 'ind:acc'there is no spacing between the two components because the previous implementation always hadaccon the left hand side. I have changed the code to store all the components (without any spacing) into an array and then finally join them into a single string at the end.Also the
ruleroption currently allowstotto be specified, altthough it isn't a valid field. I assume it was added by accident.