Refactor filename truncation code #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incidentally this also fixes a bug where the file info is misaligned when the last rune is supposed to be a double-width character and is replaced by the truncate character (which is single-width). Before: After: |
ilyagr
reviewed
May 29, 2023
There was a problem hiding this comment.
Looks nice! I am not 100% this is bug free, but I'm pretty comfortable with it. I think any bugs here would be pretty obvious for someone running the code.
I might try it out some more and/or look at the Rune functions this calls.
All of my comments are about more things we could refactor, but it might make sense to postpone that to another PR.
|
Thanks @joelim-work for the patch and thanks @ilyagr for the review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow-up of #1150, and isolates the code for handling the filename truncation so that it is done in only one place. Previously the filename would be truncated if it would overflow the pane, but if there was file info to be displayed, the filename would have to be truncated again.