Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent following symbolic links when reloading #1327

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Prevent following symbolic links when reloading #1327

merged 1 commit into from
Jul 4, 2023

Conversation

joelim-work
Copy link
Collaborator

Use the internally stored path for the new current directory instead of calling os.Getwd, which returns inconsistent results if multiple paths exist due to symbolic links.

If the current directory can be reached via multiple paths (due to symbolic links), Getwd may return any one of them.

@gokcehan gokcehan merged commit 835c5b3 into gokcehan:master Jul 4, 2023
@joelim-work joelim-work deleted the reload-stay-in-symlink branch July 4, 2023 10:01
@gokcehan gokcehan mentioned this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path doesn't preserve when reload in a symbolic linked directory
2 participants