-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improved migration creation + Windows fix (#352)
* CLI: Improve migration creation. * Validates migration version on creation, to avoid creation of duplicated versions * Uses `os.OpenFile` with `O_CREATE|O_EXCL` to create files to avoid file collisions * Uses `filepath.Join` to concatenate paths, making `cleanPath()` not necessary * Prints generated filenames * Fixes #238 * Supersedes #250 * CLI: change `createCmd` to return error and accept `print` parameter * feat: print out an abs path Better for Windows OS when specify -dir as /subdir, user will see C:/subdir/0001_name.up.sql rather than /subdir/0001_name.up.sql * test: fixed abs path test fail for OS Windows abs path tests fails because filepath.IsAbs() treats `/subdir` path as invalid abs path at windows when drive letter is not present * feat: print absolute path for created files Better for Windows OS systems where `/path` can be interpreted in different ways depending on working dir * test: corrected tests for OS Windows OS Windows has different interpretation of `/path`, it depends on working dir. If working dir D:\test it interprets `/path` as `D:\path` * test: fixed `dir invalid` test Linux OS has less restriction on a filepath than Windows, so path invalid in windows is perfectly valid for Linux. The only invalid dir name in Linux is one ending with null string terminator (\000) * refac(cli): *Cmd() now returns an error and not uses log.fatalErr(err) * docs: added godoc, migarate usage updated * refac(cli): code refactored * refac: removed unnecessary path covert * docs: comment added * test: fixed code review issue, noErrorExpected var removed #352 (comment) * docs: fixed godoc Co-authored-by: Kiyoshi '13k' Murata <[email protected]>
- Loading branch information
Showing
4 changed files
with
377 additions
and
145 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.