fix(database/clickhouse): properly escape database and table name #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is widely needed! Thank you! |
TomerGershi
approved these changes
Dec 7, 2023
|
Thanks for the fix! @jerome-quere |
dhui
reviewed
Dec 20, 2023
| @@ -192,7 +192,7 @@ func (ch *ClickHouse) SetVersion(version int, dirty bool) error { | |||
| return err | |||
| } | |||
|
|
|||
| query := "INSERT INTO " + ch.config.MigrationsTable + " (version, dirty, sequence) VALUES (?, ?, ?)" | |||
| query := "INSERT INTO `" + ch.config.MigrationsTable + "` (version, dirty, sequence) VALUES (?, ?, ?)" | |||
There was a problem hiding this comment.
Note, there are still strings that would break this. e.g. if the table or db contained a `
See also: golang/go#18478
EDIT:
You'll see that some db drivers implement this themselves
There was a problem hiding this comment.
Just merged another PR (#857) that fixes this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly escape ClickHouse table and database name when building query.
ClickHouse doc: Escape identifier