Use db.Conn to fix postgres lock/unlock #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhui
requested changes
Jan 24, 2018
| @@ -33,7 +35,8 @@ type Config struct { | |||
| } | |||
|
|
|||
| type Postgres struct { | |||
| db *sql.DB | |||
| // Locking and unlocking need to use the same connection | |||
| db *sql.Conn | |||
| @@ -1,3 +1,4 @@ | |||
| // +build go1.9 | |||
There was a problem hiding this comment.
We need to support Go 1.8 until Go 1.10 is released in Feb 2018
So we can either:
- Wait until Go 1.10 is release and we can drop Go 1.8 support and remove this build tag
- Or have a separate implementation of postgres.go which supports Go 1.8. See net/context for an example of a package supporting multiple Go versions
|
I will perhaps remake this PR myself with another file for 1.9. This is not my branch so I am actually unsure how to resolve the conflicts anyways. I will incorporate your request to rename |
|
Fixed in release v3.2.0 |
FPiety0521
pushed a commit
to FPiety0521/Golang-SQL
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @dhui , I would also like this one if possible merged in.
Thanks!